Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bottom margin to button card icon #8362

Merged
merged 1 commit into from
Feb 11, 2021
Merged

Add bottom margin to button card icon #8362

merged 1 commit into from
Feb 11, 2021

Conversation

spacegaier
Copy link
Member

Breaking change

Proposed change

Currently there is no space between the icon and the label on a button card. On big buttons you do not see it since an MDI icon rarely fills up its box until the border. But if you define your icon to be smaller it is directly glued to the label. This PR now adds a bit of space.

Before:
image

image

After:
image

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit eb235cb into dev Feb 11, 2021
@bramkragten bramkragten deleted the button-margin branch February 11, 2021 12:39
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants