Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mouseevent in blueprint import popup #8432

Merged
merged 2 commits into from
Feb 22, 2021
Merged

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Feb 22, 2021

Breaking change

Proposed change

Fixes:
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@@ -242,9 +242,9 @@ class HaBlueprintOverview extends LitElement {
});
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make a second function that handles the click on the fab:

private _addBlueprintClicked() {
	this._addBlueprint();
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh man.... I did that first... then thought, nah, Bram will not like that...

@bramkragten bramkragten merged commit e33aff7 into dev Feb 22, 2021
@bramkragten bramkragten deleted the import-blueprint-fix branch February 22, 2021 16:56
@bramkragten bramkragten mentioned this pull request Feb 22, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants