Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DE] improve homeassistant_HassTurnOn and homeassistant_HassTurnOff #1373

Merged
merged 2 commits into from
May 14, 2023
Merged

[DE] improve homeassistant_HassTurnOn and homeassistant_HassTurnOff #1373

merged 2 commits into from
May 14, 2023

Conversation

steffenrapp
Copy link
Contributor

@steffenrapp steffenrapp commented May 13, 2023 •
edited
Loading

Add <machen> for more possible commands and <schalten> for the sake of reusability.

@steffenrapp steffenrapp marked this pull request as ready for review May 13, 2023 14:33
mib1185
mib1185 approved these changes May 14, 2023
View reviewed changes
Copy link
Contributor

@mib1185 mib1185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx @steffenrapp 👍

@mib1185 mib1185 merged commit 52d3414 into home-assistant:main May 14, 2023
@steffenrapp steffenrapp deleted the de_hassturn branch May 14, 2023 18:59
@steffenrapp steffenrapp mentioned this pull request May 21, 2023
Closed
@Rexaris
Copy link

Rexaris commented Aug 10, 2023

First, thanks for your Work! Dankeschön!
I did my first steps with voice assistant an found some limitations regarding misheard words.
Is it possible to add other versions of "schalten" eg. from "(schalt[e|en])" to "(schalt[e|en|t|r])"
The reason is, that my voice recognition (self hosted faster whisper) sometimes hears "Schalter" and than it does not work.

Of course this is not limited to the word "schalten"

@tetele tetele mentioned this pull request Aug 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mib1185 mib1185 mib1185 approved these changes

@easterapps easterapps Awaiting requested review from easterapps easterapps is a code owner

Assignees
No one assigned
Labels
cla-signed lang: de
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@steffenrapp @Rexaris @mib1185