Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SL] ] Fix intents with untranslated states #1774

Merged
merged 1 commit into from
Dec 13, 2023
Merged

[SL] ] Fix intents with untranslated states #1774

merged 1 commit into from
Dec 13, 2023

Conversation

andrejs2
Copy link
Contributor

@andrejs2 andrejs2 commented Dec 12, 2023

Slovenian weather_HassGetWeather and person_HassGetState fix with untranslated states

As requested by @tetele in #1768

based on #1767

@andrejs2 andrejs2 changed the title [SL] ] Fix intents with unstranslated states [SL] ] Fix intents with untranslated states Dec 12, 2023
Da
{% else %}
Ne,
{% if state.attributes.get("untranslated_state") == "not_home" %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no need for this if if there's no difference. In English there's John is away and John is at work

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am aware that not all responses are correct. I'll have to invest additional time to extensively work on improving the extensive grammar of Slovenian.

Since there are almost no users for these intents except for me, I will have ample time to test it thoroughly.
If you think it's inadequate, that's fine with me too. I just wanted to hurry because intents and templates in yaml will take up too much of my time during the week.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whatever you think is OK. My point was that the if is redundant.

responses/sl/HassGetState.yaml Show resolved Hide resolved
@tetele
Copy link
Contributor

tetele commented Dec 13, 2023

@andrejs2 can you please merge the PR after addressing any changes you feel are necessary?

@andrejs2 andrejs2 merged commit 64d410e into home-assistant:untranslated-state Dec 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants