Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PL] Fix intents with untranslated state (#1767) AND MORE #1779

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

Uriziel01
Copy link
Contributor

@Uriziel01 Uriziel01 commented Dec 13, 2023

WARNING
This pull request contains more than just ported and translated changes from #1767, as some sentences where missing from PL version I've decided to also implement them in the same PR to avoid pushing half broken version to the repository.

I would really appreciate if any other Polish speaker would sanity check all the changes, this is more than I've initially intended but this is what had to be done in order to implement changes.

@witold-gren , @dziadeck47 , @Misiu, @fejrr, @panpawelgit

@Uriziel01
Copy link
Contributor Author

#TODO
Yes I'm aware the naive sentence in HassGetState.yaml has to be implemented to accommodate for corner cases with changes from the comment, but at this point the PR is already to large and this can be easily improved in the next iteration

@Uriziel01 Uriziel01 marked this pull request as ready for review December 13, 2023 01:04
@Uriziel01 Uriziel01 merged commit 940fb23 into untranslated-state Dec 13, 2023
2 checks passed
@Uriziel01 Uriziel01 deleted the pl-untranslated-state branch December 13, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant