Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SL] weather and person untraslated states fix #1851

Closed
wants to merge 44 commits into from
Closed

[SL] weather and person untraslated states fix #1851

wants to merge 44 commits into from

Conversation

andrejs2
Copy link
Contributor

@andrejs2 andrejs2 commented Jan 3, 2024

pushed from weather-and-person-fixes-untraslated

synesthesiam and others added 30 commits December 12, 2023 10:31
@synesthesiam
Restrict domain of climate for name
5f5f2f9
@mitrokun @HepoH3
[RU] add script_HassTurnOn support (#1772)
30a233b 
* [RU] add script_HassTurnOn support

---------

Co-authored-by: Andrei Solodovnikov <VoultBoy@yandex.ru>
@dsimop
[EL] Add HassGetWeather intents (#1775)
954d382
@dsimop
[EL] Fix weather intents with untranslated state (#1778)
3446c0d
@TheFes
[NL] Turn lights on/off in the area of a satellite (#1776)
f9f457d
@dsimop
[EL] Add HassListAddItem intents (#1780)
d5da814
@mitrokun
[RU] add sensor_HassGetState (#1789)
348516c
@joshuayuen99 @tetele
[EN] Improve light_HassLightSet sentences (#1784)
827b82a 
* Improve light_HassLightSet sentences

* Update sentences/en/light_HassLightSet.yaml

Co-authored-by: Tudor Sandu <tm.sandu@gmail.com>

* Add "of" to <in> expansion rule

---------

Co-authored-by: Tudor Sandu <tm.sandu@gmail.com>
@dontinelli
[de-CH] add nevermind (#1795)
f5e851d 
* [de-CH] slight adjustment of GetTemperature

* [de-CH] add ListAddItem

* [de-CH] implement ListAddItem

* [de-CH] implement HassGetWeather

* [de-CH] add nevermind

* test for nevermind
@andrejs2
occupancy added (#1799)
6ff7e1d
@skynetua
[uk] Added HassGetWeather intent (#1742)
bc273b4
@andrejs2
added opening and plug, modified connectivity (#1805)
e051463
@andrejs2
fixed sentence todo_HassListAddItem (#1809)
7de8b58
@dependabot
Bump isort from 5.13.0 to 5.13.2 (#1812)
fb2df0b
@dependabot
Bump black from 23.11.0 to 23.12.0 (#1811)
a954442
@dependabot
Bump pylint from 3.0.2 to 3.0.3 (#1810)
a433c4f
@dependabot
Bump actions/setup-node from 4.0.0 to 4.0.1 (#1814)
daa3562
@dependabot
Bump actions/deploy-pages from 3.0.1 to 4.0.0 (#1816)
f4306df
@slegars56
[Fr] light with satellite intents (#1818)
72b5495 
See #1815
@HarvsG
[en] Add definite article for object of HassTurnOn/HassTurnOff respon…
7198e61 
…ses (#1539)
@piitaya
Improve expansion rules for french intents (#1819)
2381a44 
* Remove variable from brightness expansion rule
* Remove variable from temperature expansion rule
* Remove area and name expansion rule
* Disambiguate words with accent
@jlpouffier
[fr] Light intents rework 20231221 (#1820)
2047d84 
General Improvement for readability and maintainability of our intents
* Remove <le> from <lumiere> and <lumieres>
* HassLightSet brightness
* HassLightSet color
* Lights HassTurnOff
* HassTurnOn Lights
* Move cover specific command to covers
* Typo
* Add optional [de]
* New tests

thanks @jlpouffier
@abmantis
[PT] Improve recognition for lists by adding "a" (#1821)
b3a270e
@HepoH3
[RU] Add turn on/off light locally (#1822)
6353efc
@phoenixperson-c137
Fix Hebrew response for HassClimateGetTemperature (#1828)
555a848 
* Fix Hebrew response for HassClimateGetTemperature

The Hebrew response for HassClimateGetTemperature returned the climate's state, rather than the current temp.

Also, when a sentence in Hebrew starts with a number, or an english letter, it jumbles it.

Fixed the value and added the name of the area to the beginning of the sentence to avoid it getting jumbled.

The new sentence translates to  "In {area} {temperature} degrees" (no need for ["it is"] between area and temperature in Hebrew)

* Add support for not providing area, add tests
@dependabot
Bump actions/deploy-pages from 4.0.0 to 4.0.2 (#1827)
2f489f0
@dependabot
Bump black from 23.12.0 to 23.12.1 (#1826)
6a082d8
@dependabot
Bump regex from 2023.10.3 to 2023.12.25 (#1825)
d2fbe0f
@dependabot
Bump mypy from 1.7.1 to 1.8.0 (#1824)
a71f4a3
@svillar
[GL] ListAddItem sentences (#1762)
e6200ae 
Adding ListAddItem sentences, responses and tests for Galician.
tetele
tetele requested changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@tetele tetele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clean the PR and include only your modifications

@home-assistant home-assistant bot marked this pull request as draft January 3, 2024 11:18
@home-assistant
Copy link

home-assistant bot commented Jan 3, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@andrejs2
Copy link
Contributor Author

andrejs2 commented Jan 3, 2024

Please clean the PR and include only your modifications

I really don't know how to handle this. After I made changes to responses (HassGetState.yaml) I broke some other tests for person and weather. I did rebase with branch but then it includes other commits....ahhh.

Is it ok to close this PR? I'll wait with PR (open new PR) till this is resolved and merged...

@HepoH3 HepoH3 mentioned this pull request Jan 3, 2024
Closed
@tetele
Copy link
Contributor

tetele commented Jan 3, 2024

Is it ok to close this PR? I'll wait with PR (open new PR) till this is resolved and merged...

That will probably be the easier thing to do. So... any PR that you create should only contain your updates. This is really important!

It's ok if you don't merge for now and me and/or @synesthesiam will try to do that when the functionality is ready.

Thanks!

@andrejs2
Copy link
Contributor Author

andrejs2 commented Jan 3, 2024

Is it ok to close this PR? I'll wait with PR (open new PR) till this is resolved and merged...

That will probably be the easier thing to do. So... any PR that you create should only contain your updates. This is really important!

It's ok if you don't merge for now and me and/or @synesthesiam will try to do that when the functionality is ready.

Thanks!

@tetele Thanks!

@andrejs2 andrejs2 closed this Jan 3, 2024
@jlpouffier jlpouffier mentioned this pull request Jan 5, 2024
Closed
@andrejs2 andrejs2 deleted the new branch March 1, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tetele tetele tetele requested changes

@skynetua skynetua Awaiting requested review from skynetua skynetua is a code owner

@HepoH3 HepoH3 Awaiting requested review from HepoH3 HepoH3 is a code owner

@abmantis abmantis Awaiting requested review from abmantis abmantis is a code owner

@joaorgoncalves joaorgoncalves Awaiting requested review from joaorgoncalves joaorgoncalves is a code owner

@TheFes TheFes Awaiting requested review from TheFes TheFes is a code owner

@LaStrada LaStrada Awaiting requested review from LaStrada LaStrada is a code owner

@haim-b haim-b Awaiting requested review from haim-b haim-b is a code owner

@leranp leranp Awaiting requested review from leranp leranp is a code owner

@cibernox cibernox Awaiting requested review from cibernox cibernox is a code owner

@flexy2dd flexy2dd Awaiting requested review from flexy2dd

@dsimop dsimop Awaiting requested review from dsimop

@dontinelli dontinelli Awaiting requested review from dontinelli dontinelli is a code owner

@easterapps easterapps Awaiting requested review from easterapps easterapps is a code owner

@mib1185 mib1185 Awaiting requested review from mib1185 mib1185 is a code owner

Assignees
No one assigned
Labels
cla-signed lang: de lang: el lang: en lang: fr lang: gl lang: he lang: nb lang: nl lang: ru lang: sl lang: uk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.