Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn users only when old config is actually used #4691

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Conversation

agners
Copy link
Member

@agners agners commented Nov 10, 2023

Proposed change

The intention is to warn if the old "config" is used while also one of the new "homeassistant_config" or "addons_config" is used.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to cli pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

The intention is to warn if the old "config" is used while also
one of the new "homeassistant_config" or "addons_config" is
used.
@agners agners added bug bugfix A bug fix and removed bug labels Nov 10, 2023
@frenck frenck merged commit 68da328 into main Nov 10, 2023
25 of 26 checks passed
@frenck frenck deleted the fix-config-warning branch November 10, 2023 18:37
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants