Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add music assistant to the builtin repositories #5128

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Conversation

pvizeli
Copy link
Member

@pvizeli pvizeli commented Jun 7, 2024

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to cli pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Ruff (ruff format supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

Summary by CodeRabbit

  • New Features

    • Added support for the "Music Assistant" repository to the list of available repositories.
  • Tests

    • Updated test cases to accommodate the new "Music Assistant" repository URL.
    • Added new assertions to ensure the validation of the "Music Assistant" repository.

This comment was marked as resolved.

@pvizeli pvizeli added the new-feature A new feature label Jun 7, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks, @pvizeli & @agners 👍

../Frenck

@agners agners merged commit c37b5ef into main Jun 21, 2024
19 checks passed
@agners agners deleted the music-assistant branch June 21, 2024 10:17
@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants