Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Economizer: implement the feature #238

Closed
climategadgets opened this issue Oct 1, 2022 · 0 comments
Closed

Economizer: implement the feature #238

climategadgets opened this issue Oct 1, 2022 · 0 comments
Labels
economizer enhancement process control reactive-only Will be fixed in Reactive branches only
Milestone
Implement the eco...

Comments

@climategadgets
Copy link
Member

climategadgets commented Oct 1, 2022 •
edited
Loading

Task Definition

Data structures created in #237 are turned into code supporting the feature.
@climategadgets climategadgets added this to the Future Feature #2 milestone Oct 1, 2022
@climategadgets climategadgets added the reactive-only Will be fixed in Reactive branches only label Oct 1, 2022
@climategadgets climategadgets changed the title Future feature #2: implement the feature Economizer: implement the feature Oct 12, 2022
climategadgets added a commit that referenced this issue Oct 12, 2022
@climategadgets
Added draft economizer implementation, kinks still need to be fixed (#…
955ec17 
…238)
climategadgets added a commit that referenced this issue Oct 12, 2022
@climategadgets
Added test case, fixed kinks (#238)
56b9d6a
climategadgets added a commit that referenced this issue Oct 19, 2022
@climategadgets
Renamed a method for clarity, improved docs (#238)
eeb79b4
climategadgets added a commit that referenced this issue Oct 19, 2022
@climategadgets
Documentation update (#238)
02feae4
climategadgets added a commit that referenced this issue Oct 19, 2022
@climategadgets
Renamed a class to avoid confusion between a concrete class and an in…
1c8bd81 
…terface (#238)
climategadgets added a commit that referenced this issue Oct 20, 2022
@climategadgets
Removed human readable name - will not be useful (#238)
1abe0c6
climategadgets added a commit that referenced this issue Oct 20, 2022
@climategadgets
Documentation update (#238)
90ff4da
climategadgets added a commit that referenced this issue Oct 20, 2022
@climategadgets
Changed the economizer instantiation model (#238)
04e5132
climategadgets added a commit that referenced this issue Oct 20, 2022
@climategadgets
Changed economizer invocation model (#238)
1b07e91
climategadgets added a commit that referenced this issue Oct 20, 2022
@climategadgets
Integrated Economizer into Zone (#238)
9962c7e
climategadgets added a commit that referenced this issue Oct 20, 2022
@climategadgets
Dodged race condition GitHub Actions build hits (#238)
2438b2a
climategadgets added a commit that referenced this issue Oct 20, 2022
@climategadgets
Now turning off the economizer actuator device on shutdown (#238)
7234a91
climategadgets added a commit that referenced this issue Oct 21, 2022
@climategadgets
Economizer pipeline is a bit more reactive now (#238)
c6056dd
climategadgets added a commit that referenced this issue Oct 21, 2022
@climategadgets
Now propagating PID status further so that it can be reported (#238)
5926df3
climategadgets added a commit that referenced this issue Oct 21, 2022
@climategadgets
Trivial refactoring (#238)
cef1749
climategadgets added a commit that referenced this issue Nov 14, 2022
@climategadgets
Added reasonable economizer PID controller defaults (#238)
b35d6f6
climategadgets added a commit that referenced this issue Nov 14, 2022
@climategadgets
Economizer now inherits the name from the zone and doesn't have its o…
8be7bd4 
…wn (#238)
climategadgets added a commit that referenced this issue Nov 14, 2022
@climategadgets
Documentation update (#238)
127e0e9
climategadgets added a commit that referenced this issue Nov 14, 2022
@climategadgets
Now economizer settings can be merge()d just like zone settings (#238)
56b00e0
climategadgets added a commit that referenced this issue Nov 14, 2022
@climategadgets
Yielded to Sonar nagging (#238)
e6b25cc
climategadgets added a commit that referenced this issue Oct 11, 2023
@climategadgets
Removed redundant argument (#238, #290)
d09a207
climategadgets added a commit that referenced this issue Oct 11, 2023
@climategadgets
Bugfix that broke everything (details below) (#238, #271, #290)
fc34be5 
Original problem: feedback wasn't engaged when economizer wasn't configured
due to a typo

Collateral and deal breaker: fixing the bug makes test cases stall, though
the application somehow keeps working.

This very likely pinpoints the root cause of #290.
climategadgets added a commit that referenced this issue Oct 11, 2023
@climategadgets
Bugfix, complication (details below) (#238, #271, #290)
315d554 
Original problem: feedback wasn't engaged when economizer wasn't configured
due to a typo

Collateral: feedbackFlux is not closed, this is why test cases stall.  Fix
is in the next commit.
climategadgets added a commit that referenced this issue Oct 11, 2023
@climategadgets
Bugfix complication removed (fixed test cases) (#238, #271, #290)
71a8438
climategadgets added a commit that referenced this issue Oct 12, 2023
@climategadgets
Moved bugfix (rev. 71a8438) into a better place (#238, #271, #290)
e4d4798
climategadgets added a commit that referenced this issue Nov 2, 2023
@climategadgets
Economizer stale timeout is now configurable (#47, #238)
8932aef
climategadgets added a commit that referenced this issue Apr 22, 2024
@climategadgets
Downgraded the log message - this situation is often encountered (#238)
a99ae35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
economizer enhancement process control reactive-only Will be fixed in Reactive branches only
Projects
None yet
Milestone
Implement the economizer
Development

No branches or pull requests
1 participant
@climategadgets