Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: enforce ISO-8601 in deprecation date #7835

Merged
merged 1 commit into from Jun 26, 2020

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Jun 26, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Add RuboCop check to make sure deprecate! date is ISO-8601 compliant

Corresponding homebrew-core PR: Homebrew/homebrew-core#56903

Copy link
Member

@sjackman sjackman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Rylan!

Library/Homebrew/rubocops/deprecate.rb Outdated Show resolved Hide resolved
Library/Homebrew/rubocops/deprecate.rb Outdated Show resolved Hide resolved
Copy link
Member

@bayandin bayandin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 👍

@Rylan12
Copy link
Member Author

Rylan12 commented Jun 26, 2020

Thanks! Once the formulae are merged into linuxbrew-core I'll rerun the CI and (assuming it's green) merge this PR.

Copy link
Member

@reitermarkus reitermarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nitpick: ISO 8601 instead of ISO-8601

@Rylan12 Rylan12 merged commit 1df0a62 into Homebrew:master Jun 26, 2020
@Rylan12 Rylan12 deleted the rubocop-deprecation-date branch June 26, 2020 20:19
@reitermarkus
Copy link
Member

@Rylan12, the tests still use ISO-8601, would be great if you could also change them to ISO 8601.

@Rylan12
Copy link
Member Author

Rylan12 commented Jun 26, 2020

@reitermarkus Ahh, you're right. Looks like I jumped the gun a little on this one. Apologies for that.

Can I commit these directly or should I still make a PR?

@reitermarkus
Copy link
Member

Always create a PR so that CI can run on it before merging.

@Rylan12
Copy link
Member Author

Rylan12 commented Jun 27, 2020

Makes sense. I'll cc you on the PR. Thanks!

@MikeMcQuaid
Copy link
Member

Nice work @Rylan12!

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 27, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants