Hide follower-only pinned statuses from logged-out users #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnholdun
commented
Nov 10, 2022
| @@ -29,7 +29,7 @@ def show | |||
| end | |||
|
|
|||
| if current_user.nil? | |||
| @pinned_statuses = cache_collection(@account.pinned_statuses.without_local_only, Status) if show_pinned_statuses? | |||
| @pinned_statuses = cache_collection(filtered_pinned_statuses.without_local_only, Status) if show_pinned_statuses? | |||
There was a problem hiding this comment.
This scoped collection was already defined in the profile—it limits to just pinned statuses that have a visibility of public or unlisted, then the without_local_only scope further limits the collection.
johnholdun
force-pushed
the
hide-private-pinned-statuses
branch
from
bd93346
to
7eedaeb
Compare
johnholdun
commented
Nov 10, 2022
| @@ -120,6 +120,11 @@ | |||
| expect(response.body).to include(I18n.t('stream_entries.pinned')) | |||
| end | |||
|
|
|||
| it 'does not render private pinned status' do | |||
There was a problem hiding this comment.
This spec should pass but something about my local environment was making controller specs raise errors. Something about Webpack not generating a manifest. I'll look into this in the future, but I wanted to make sure this was in here.
|
Thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1178