Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[optimization] simple concat for prepending "app." #328

Merged
merged 1 commit into from
Jun 2, 2022
Merged

[optimization] simple concat for prepending "app." #328

merged 1 commit into from
Jun 2, 2022

Conversation

lizthegrey
Copy link
Member

@lizthegrey lizthegrey commented Jun 1, 2022 •
edited
Loading

Which problem is this PR solving?

Short description of the changes

  • Avoid using fmt.Sprintf for a very simple operation. This hopefully gets rid of some inefficiency/allocations that otherwise are plaguing shepherd at high volume.

@lizthegrey
[optimization] simple concat for prepending "app."
288902e 
this hopefully gets rid of some inefficiency/allocations that otherwise are plaguing shepherd at high volume.
@lizthegrey lizthegrey marked this pull request as ready for review June 1, 2022 21:58
@lizthegrey lizthegrey requested a review from a team June 1, 2022 21:58
@MikeGoldsmith MikeGoldsmith merged commit c88dacb into main Jun 2, 2022
@MikeGoldsmith MikeGoldsmith deleted the lizf.optimize-hot-path branch June 2, 2022 13:41
lizthegrey added a commit that referenced this pull request Jun 3, 2022
@lizthegrey
[optimization] unconditional string construction
e364c3a 
Follow-up to #328 as I realised that the Go compiler may need hinting about the `"app." +` happening always for it to compile time simplify.
@lizthegrey lizthegrey mentioned this pull request Jun 3, 2022
Closed
@JamieDanielson JamieDanielson added type: maintenance The necessary chores to keep the dust off. version: bump patch A PR with release-worthy changes and is backwards-compatible. labels Jun 8, 2022
@lizthegrey lizthegrey mentioned this pull request Nov 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes

Assignees
No one assigned
Labels
type: maintenance The necessary chores to keep the dust off. version: bump patch A PR with release-worthy changes and is backwards-compatible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lizthegrey @MikeGoldsmith @JamieDanielson