Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: send request/response body size #80

Merged
merged 1 commit into from
Aug 17, 2023
Merged

feat: send request/response body size #80

merged 1 commit into from
Aug 17, 2023

Conversation

pkanal
Copy link
Contributor

@pkanal pkanal commented Aug 17, 2023

Which problem is this PR solving?

Short description of the changes

  • Use Content-Length header to send request / response body size

How to verify that this has the expected result

Screenshot 2023-08-17 at 9 50 12 AM

@pkanal pkanal self-assigned this Aug 17, 2023
@pkanal pkanal requested a review from a team August 17, 2023 13:50
vreynolds
vreynolds approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@vreynolds vreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like with the EGS test, request content-length is always 0 -- not sure if that's just a quirk of our test setup, or if it's common to not have that header on requests. We can see what it looks like in a real cluster!

@pkanal
Copy link
Contributor Author

pkanal commented Aug 17, 2023

It looks like with the EGS test, request content-length is always 0 -- not sure if that's just a quirk of our test setup, or if it's common to not have that header on requests. We can see what it looks like in a real cluster!

The request body content length will be 0 for GET requests! POST requests should have a content length but we don't support those with EGS.

@pkanal pkanal merged commit 97ddeed into main Aug 17, 2023
3 checks passed
@pkanal pkanal deleted the purvi/body-size branch August 17, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vreynolds vreynolds vreynolds approved these changes

Assignees

@pkanal pkanal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Record request and response body size
2 participants
@pkanal @vreynolds