Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add batch span processor #14

Closed
Tracked by #3
emilyashley opened this issue Dec 1, 2022 · 0 comments · Fixed by #27
Closed
Tracked by #3

Add batch span processor #14

emilyashley opened this issue Dec 1, 2022 · 0 comments · Fixed by #27
Milestone

Comments

@emilyashley
Copy link
Contributor

No description provided.

@MikeGoldsmith MikeGoldsmith added this to the Beta milestone Dec 5, 2022
@MikeGoldsmith MikeGoldsmith changed the title add batch span processor Add batch span processor Dec 12, 2022
robbkidd added a commit that referenced this issue Dec 12, 2022
## Which problem is this PR solving?
As we develop more functionality into the Honeycomb distro, setting
environment variables doesn't offer enough flexability for our needs.
This PR updates the distro to instead configure both the tracer and
meter providers directly by configuring their exporters.

This will enable additional resources (eg span processors or samplers)
to be added later.

- Closes #14 
- Closes #11 

## Short description of the changes
- [x] Adds openetelemetry-otlp-exporter as dependency
- [x] Add create_tracer_provider func to tracing.py
- [x] Add create_meter_provider func to metrics.py
- [x] Wire tracing and meter provider pipelines using options & resource
in distro/configure_opentelemetry
- [x] Update HoneycombOptions with member functions to get trace & meter
exporter credentials & headers
- [x] Add simple test to verify new tracer / meter provider creation
funcs return expected types
- [x] Remove env var based tests from test_distro.py
- [x] Update distro/configure_opentelemetry to take HoneycombOptions arg
instead of discrete optional fields
- [x] Re-add custom instrumentation to example app to show how to create
additional spans

Co-authored-by: Robb Kidd <robbkidd@honeycomb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants