Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maint: drop poetry locks from example apps #111

Merged
merged 3 commits into from
Mar 29, 2023
Merged

maint: drop poetry locks from example apps #111

merged 3 commits into from
Mar 29, 2023

Conversation

JamieDanielson
Copy link
Contributor

Which problem is this PR solving?

  • increase confidence in new installs

Short description of the changes

  • update opentelemetry-api dep in example python app
  • remove poetry locks from example apps
  • gitignore poetry locks in example apps

How to verify that this has the expected result

smoke tests pass

@JamieDanielson JamieDanielson requested a review from a team March 29, 2023 14:39
vreynolds
vreynolds approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@vreynolds vreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤠

@JamieDanielson JamieDanielson added type: maintenance The necessary chores to keep the dust off. version: no bump A PR with maintenance or doc changes that aren't included in a release. labels Mar 29, 2023
@JamieDanielson JamieDanielson self-assigned this Mar 29, 2023
@JamieDanielson JamieDanielson merged commit d8a6449 into main Mar 29, 2023
@JamieDanielson JamieDanielson deleted the jamie.drop-poetry-locks branch March 29, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vreynolds vreynolds vreynolds approved these changes

Assignees

@JamieDanielson JamieDanielson

Labels
type: maintenance The necessary chores to keep the dust off. version: no bump A PR with maintenance or doc changes that aren't included in a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamieDanielson @vreynolds