Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: Include LICENSES in distributions #297

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Conversation

TylerHelmuth
Copy link
Contributor

Which problem is this PR solving?

  • Includes our dependency's licenses in our distribution

Short description of the changes

  • add makefile targets to update and verify licesnes
  • add LICENSES folder with all dependency licenses
  • Add job to CI to ensure LICENSES is up-to-date.

@TylerHelmuth TylerHelmuth requested a review from a team as a code owner April 7, 2023 18:50
Copy link
Contributor

@kentquirk kentquirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch. This thing apparently thinks the Go mysql driver license requires full source distribution. I'm not sure I agree, but it's not worth arguing about.

@TylerHelmuth
Copy link
Contributor Author

@kentquirk ya based on the license type it makes decisions about whether or not the code requires only the licenses to be distributed or the source code as well.

@TylerHelmuth TylerHelmuth merged commit e284060 into main Apr 7, 2023
@TylerHelmuth TylerHelmuth deleted the distribute-licenses branch April 7, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants