Workaround for #3 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bad workaround in order to fix a strange behaviour in com/dtmilano/android/viewclient.py. If serial=None it tries to take arbitrary parameter to fill serial with nonsense. The Workaround set all serial=None to serial='.*'.
My workaround in 4ea87c9 has the same effect, but it does not change the external code.
|
Thanks, your fix is better. |
yuanchun-li
added a commit
that referenced
this pull request
Jul 17, 2015
Workaround for #3 better fix of serialno
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if this is a good fix. But I think your and my fix does the same, it sets
The advantage of my workaround is, that we does not change the external code. If we want to update the external code, it would be easier. Perhaps there is also another way, then copying the external code into the droidbot repository.