Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement myqueries page using routify #77

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Implement myqueries page using routify #77

merged 1 commit into from
Aug 15, 2023

Conversation

dkumiszhan
Copy link
Collaborator

Client side rendering is used for rendering the page.
There are some TODOs related to CORS and making Golang backend
and Svelte frontend work together. I will tackle those later
in separate PRs.

This PR contains the first commit from #76. I will rebase once the other PR is merged.

@glaslos
Copy link
Member

glaslos commented Aug 5, 2023

Conflicts need to be resolved.

@dkumiszhan
Copy link
Collaborator Author

Conflicts need to be resolved.

done

backend/handlers.go Show resolved Hide resolved
backend/handlers.go Show resolved Hide resolved
backend/handlers.go Show resolved Hide resolved
backend/handlers.go Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
tsconfig.json Show resolved Hide resolved
Client side rendering is used for rendering the page.
There are some TODOs related to CORS and making Golang backend
and Svelte frontend work together. I will tackle those later
in separate PRs.
Copy link
Member

@glaslos glaslos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry for the late review!

@glaslos glaslos merged commit 87d571e into main Aug 15, 2023
2 checks passed
@glaslos glaslos deleted the query-ui branch August 15, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants