-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement myqueries
page using routify
#77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkumiszhan
force-pushed
the
query-ui
branch
2 times, most recently
from
August 3, 2023 23:30
7efd058
to
82b3627
Compare
Conflicts need to be resolved. |
done |
This was referenced Aug 7, 2023
glaslos
requested changes
Aug 10, 2023
Client side rendering is used for rendering the page. There are some TODOs related to CORS and making Golang backend and Svelte frontend work together. I will tackle those later in separate PRs.
glaslos
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Sorry for the late review!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client side rendering is used for rendering the page.
There are some TODOs related to CORS and making Golang backend
and Svelte frontend work together. I will tackle those later
in separate PRs.
This PR contains the first commit from #76. I will rebase once the other PR is merged.