Dash.js version

[YaxiongXiePrinceton]

Can I ask which version of dash.js code are you using when building pensive project?

I ask this question because the code of dash.js has changed so much and I want to compare what kind of changes you have made to the dash.js project.

Thanks and regards.

[hongzimao]

I believe it's dash.js v2.0. We have a mirror copy of the dash.js code for the project: https://github.com/hongzimao/pensieve/tree/master/dash.js

[YaxiongXiePrinceton]

Thanks for your quick response. I saw the mirror copy of the dash.js code. But the code is after your modifications. So, I am wondering if I can get the exact version of dash.js so that I can compare the original code with your modifications. Here list all the versions of dash.js https://github.com/Dash-Industry-Forum/dash.js/tags?after=v2.9.0

…

________________________________ From: Hongzi Mao <notifications@github.com> Sent: Tuesday, July 21, 2020 10:29 PM To: hongzimao/pensieve <pensieve@noreply.github.com> Cc: Yaxiong Xie <yaxiongx@princeton.edu>; Author <author@noreply.github.com> Subject: Re: [hongzimao/pensieve] Dash.js version (#109) I believe it's dash.js v2.0. We have a mirror copy of the dash.js code for the project: https://github.com/hongzimao/pensieve/tree/master/dash.js — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#109 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJ64W57TQ452PE7VWVAWIQLR4ZFIVANCNFSM4PEHFCRQ>.

[hongzimao]

I see what you need to do. I just checked our development branch and it seems we downloaded a version around Oct 2016. Unfortunately I can't find the exact dash version. But can you diff on the dash versions before this date and after v2.0 (i.e., v2.0.0 - v2.3.0 in https://github.com/Dash-Industry-Forum/dash.js/tags?after=v2.6.1). It's likely that you can find the right version by finding the least amount of diff.

I don't think we add more than a thousand lines of code in dash. Remember to only diff on the source code but not the compiled files like dash.all.min.js.

Hope this helps!

[hongzimao]

Feel free to confirm here the files and the code we modified when you find the version with least amount of diff. We can then double check. Thanks!

[YaxiongXiePrinceton]

Got it. I will update when I get the results. Thanks for your help, it really helps.

…

________________________________ From: Hongzi Mao <notifications@github.com> Sent: Tuesday, July 21, 2020 10:49 PM To: hongzimao/pensieve <pensieve@noreply.github.com> Cc: Yaxiong Xie <yaxiongx@princeton.edu>; Author <author@noreply.github.com> Subject: Re: [hongzimao/pensieve] Dash.js version (#109) I see what you need to do. I just checked our development branch and it seems we downloaded a version around Oct 2016. Unfortunately I can't find the exact dash version. But can you diff on the dash versions before this date and after v2.0 (i.e., v2.0.0 - v2.3.0 in https://github.com/Dash-Industry-Forum/dash.js/tags?after=v2.6.1). It's likely that you can find the right version by finding the least amount of diff. I don't think we add more than a thousand lines of code in dash. Remember to only diff on the source code but not the compiled files like dash.all.min.js. Hope this helps! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#109 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJ64W53C5GFDVCBWQ2NAZADR4ZHTNANCNFSM4PEHFCRQ>.

[YaxiongXiePrinceton]

I guess it is dash.js-2.3.0.

[hongzimao]

This looks right. We mainly changed AbrController.js.

[YaxiongXiePrinceton]

Yep. I believe we found the correct version.