fix(middleware): Context declaration #2694
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @MonsterDeveloper thank you for the PR! About the PR, can you wait for me to merge? Perhaps it will be fixed completely if Hono supports JSR. |
yusukebe
reviewed
May 18, 2024
|
I got it. We should extend |
|
Oh my lovely TypeScript:) Corrected to |
|
But now Deno is not happy... |
|
Oh... Then, wait until this PR is merged. The next minor version may be released soon, and it will be merged at that time! |
|
The issue was fixed. This PR is not needed. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2693
@yusukebe not sure it's the best way though, as
denoifyautomatically addsnode:tohonoimport... Without this import TS yells thathonois an "unknown" module...The author should do the following, if applicable
Add tests(n/a)bun denoifyto generate files for Denobun run format:fix && bun run lint:fixto format the code