Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RemovedInDjango19Warning (2) #73

Closed
vmarkovtsev opened this issue Oct 6, 2015 · 1 comment
Closed

RemovedInDjango19Warning (2) #73

vmarkovtsev opened this issue Oct 6, 2015 · 1 comment

Comments

@vmarkovtsev
Copy link
Contributor

I think this is different from #71

When I try to use ThreadedComment model in my app, I get a single

threadedcomments/models.py:9: RemovedInDjango19Warning: Model class threadedcomments.models.ThreadedComment doesn't declare an explicit app_label and either isn't in an application in INSTALLED_APPS or else was imported before its application was loaded. This will no longer be supported in Django 1.9.
  class ThreadedComment(Comment)

After reading for example this question on StackOverflow and examining how similar projects were fixed (https://github.com/DanielJDufour/python-social-auth/commit/b51629fcc54ad755f1b17f27712aacc860f34129), I suggest to remove imports from init. ThreadedComments model is imported during package import, before Django app is initialized, thus the warning is printed.

vmarkovtsev added a commit to vmarkovtsev/django-threadedcomments that referenced this issue Oct 6, 2015
@vdboor
Copy link
Collaborator

vdboor commented Oct 7, 2015

Thanks! the pull request is merged!
If you see any other Django 1.9 issues, don't hesitate to make another PR!

@vdboor vdboor closed this as completed Oct 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants