Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor to use npm instead of custom caching #135

Merged
merged 11 commits into from
Jul 25, 2014
Merged

refactor to use npm instead of custom caching #135

merged 11 commits into from
Jul 25, 2014

Conversation

svnlto
Copy link
Contributor

@svnlto svnlto commented Jul 21, 2014

Please test this throughly and report back any errors.

@janl @boennemann @caolan @gr2m

@boennemann
Copy link
Contributor

@svnlto Haven't had the time to test this yet, but I wanted to ask what the status of using subfolders in templates is, because the release process setup for my-first-hoodie kind of depends on this.

@svnlto
Copy link
Contributor Author

svnlto commented Jul 21, 2014

@boennemann could you maybe explain what you mean by that? The way templates get handled in this branch, is that we do a npm install and then move the folder out into a folder with the provided name.

@boennemann
Copy link
Contributor

@svnlto I mean rather than copying the template from the my-first-hoodie repository's root folder use a subfolder like template/.

@svnlto
Copy link
Contributor Author

svnlto commented Jul 21, 2014

Why? Oh you mean, have a different structure inside my-first-hoodie altogether?

@boennemann
Copy link
Contributor

Will describe this in another issue. Let's get back to this PR.

@gr2m
Copy link
Contributor

gr2m commented Jul 22, 2014

@svnlto just to make sure I'm doing it correctly, can you explain how to link the npm branch to my local hoodie cli command?

@svnlto
Copy link
Contributor Author

svnlto commented Jul 22, 2014

@gr2m you need to use the npm link command for that. Switch to the npm branch, run npm link, then you'll have the hoodie-cli command globally available.

@boennemann
Copy link
Contributor

Haven't tested this locally, but the integration tests now run against those changes which means everything seems to be fine.

@gr2m
Copy link
Contributor

gr2m commented Jul 23, 2014

I see a lot of Reading config from /private/tmp/funky/data/config.json. in the terminal (looks like a debug console.log?)
https://gist.github.com/c7ac01f14ec6013db101

Also the output of hoodie start is the same as hoodie start -v

Besides that, looks all good 👍

@svnlto
Copy link
Contributor Author

svnlto commented Jul 23, 2014

I see a lot of Reading config from /private/tmp/funky/data/config.json. in the terminal (looks like a debug console.log?)
https://gist.github.com/c7ac01f14ec6013db101

that's to do with a PR on hoodie-server I'll fix that soon.

Also the output of hoodie start is the same as hoodie start -v

The start command, doesn't have a -v option. You want to use that with the new command.

svnlto added a commit that referenced this pull request Jul 25, 2014
refactor to use npm instead of custom caching
@svnlto svnlto merged commit 7a6c4fd into master Jul 25, 2014
@svnlto svnlto deleted the npm branch July 25, 2014 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants