Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust POST /requests spec #16

Closed
4 tasks done
gr2m opened this issue Dec 12, 2015 · 1 comment
Closed
4 tasks done

Adjust POST /requests spec #16

gr2m opened this issue Dec 12, 2015 · 1 comment
Assignees

Comments

@gr2m
Copy link
Member

gr2m commented Dec 12, 2015

current state is at
http://docs.accountjsonapi.apiary.io/#reference/requests/request-collection/create

source is here:
https://github.com/hoodiehq/account-json-api/blob/master/apiary.apib#L725


  • start a PR
  • Add 201 response: links.self is optional. If no resource is persisted in the database, it won't be set (not relevant anymore, see comment below)
  • specify a response if request handler is not implemented (403 maybe)?
  • review & merge
@patriciagarcia
Copy link
Collaborator

As discussed with @gr2m, we'll always return links.self but until the persistence layer for requests is implemented, GET /requests/<request_id> will return 404.

  • Add 201 response: links.self is optional. If no resource is persisted in the database, it will not be set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants