Add attributes section to sign up request and optional attributes #28
Conversation
| + attributes (object, required) | ||
| + username (string, required) | ||
| + password (string, required) | ||
| + createdAt (string, optional) - timestamp the user account was created on the client |
There was a problem hiding this comment.
To show the difference between optional and required request body attributes, it was necessary to add this. What other optional attributes are can be sent? Also, id inside attributes or outside like it is now?
There was a problem hiding this comment.
I think I would leave out the createdAt attribute here, and set username & password to optional. They are just examples, the app implementing the spec can decide what attributes they want to use for their accounts.
|
Hey @barretodaniel, are you on twitter? We like giving shout outs to new contributors :) Only if you like of course |
|
I have a twitter but it's been a few months since I've used it lol. I
|
|
BTW, we still have that other open issue. Are we okay to start implementing the server route? |
|
yes we are :) Thanks for your help Daniel :) |
|
Awwwwww 🎉 |
|
Honestly, working on this has increased my comfort level with contributing tremendously. It's a nice feeling and I'm excited to continue contributing. |
|
that is really nice to hear, thanks Daniel! It’s really exactly the reason why we invest so much into being the most welcoming community possible :) |
closes #15