test: admin.signOut() throws error when signed out #113
Conversation
admin.signOut() throws `TypeError: Cannot read property 'session' of null` when a user is not signed in. This commit contains documentation and failing unit/integration test updates in order to catch the condition where a user has attempted to sign out without being signed in and, rather than throwing the current error, throw an `UnauthenticatedError: Not signed in` error, instead.
Fix implemented. Unit and integration tests pass.
|
|
||
| // simulate user who has not yet signed in | ||
| store.clear() | ||
| store.setObject('account', {}) |
There was a problem hiding this comment.
When simulating a user who is not signed in, Is it sufficient to set the account object to an empty object literal, or should there be more items in the object? From the code, it seems that having a session object inside of the account object implies that the user is logged in, so I wouldn't want to add a session object, but I didn't know if any other information is necessary in the account object to simulate a user who is not signed in.
There was a problem hiding this comment.
the store.clear() should be sufficient here. The account.signOut() call should not require account to be stored as an empty {} in the store. Compare for example to the .signIn() integration test
|
|
||
| function signOut (state) { | ||
| if (!internals.isSignedIn(state)) { | ||
| return Promise.reject(new Error('UnauthenticatedError: Not signed in')) | ||
| } |
1. Only clearing store and not creating an empty account object, as one is not required for `account.signOut()`. 2. Removing `id` from `account` instance, as it's not required for this test and one will be randomly assigned.
|
@gr2m Thanks for your guidance. Corrections made. |
|
LGTM ✨ |
|
Great work, thanks @capellini 👏 LGTM |
|
released as v4.1.1 |
admin.signOut() throws
TypeError: Cannot read property 'session' of nullwhen a user is not signed in. This commit contains documentation and failing unit/integration test updates in order to catch the condition where a user has attempted to sign out without being signed in and, rather than throwing the current error, throw anUnauthenticatedError: Not signed inerror, instead.closes hoodiehq/camp#12