Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Source Pair Programming meetup: Initial steps for Hoodie upgrading #14

Merged
merged 11 commits into from
Sep 11, 2016

Conversation

machikoyasuda
Copy link
Contributor

Paired with @davidtansf @dj-m @gr2m

We fixed many console errors and added one feature: adding sign-in with sign-up function. Now we want to get the $map.hammer on touch event handler.

@gr2m
Copy link
Member

gr2m commented Jul 28, 2016

@machikoyasuda @davidtansf @dj-m couldn’t help myself, fixed the issue via d4e5ad6

Give it a try, I’m sure there are still a few things left. I also had to work around hoodiehq/hoodie-store-client#95 (by doing hoodie.store.on('change', handle) instead of scoped event handlers like hoodie.store('marker').on('change', hangler)) and I’ve to look into how we can distinguish changes coming from remote via sync from changes caused by user interaction. Right now when a new maker comes from remote, it gets highlighted on the map as if the user just created it.

@gr2m
Copy link
Member

gr2m commented Sep 11, 2016

thanks y’all 👏 The new app is still a little buggy, but we’re getting there :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants