Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compliant WSDL doesn't parse some constants and nested complexType objects correctly #16

Closed
beckler opened this issue Nov 5, 2014 · 3 comments

Comments

@beckler
Copy link

beckler commented Nov 5, 2014

This WSDL is SOAP 1.1, and claims to be WS-I 1.0 compliant, but gowsdl can't seem to handle some of the objects that are nested complexTypes. The formatter fails because some types don't seem to be parsed correctly.
These are two general examples I have been running into:

// Constants with odd characters (spaces and hyphens)
// generated code
const (
DriveTrain_Front Wheel Drive DriveTrain = "Front Wheel Drive" 
)
// I believe should be
const (
DriveTrain_Front_Wheel_Drive DriveTrain = "Front Wheel Drive" 
)

// Constants with hyphens
// generated code
const(
SwitchChromeMediaGallery_Multi-View SwitchChromeMediaGallery = "Multi-View"
)
// I believe should be
const(
SwitchChromeMediaGallery_Multi_View SwitchChromeMediaGallery = "Multi-View"
)
// Structs with no objects
type VersionInfo struct {
    XMLName xml.Name `xml:"urn:description7a.services.chrome.com VersionInfo"`
    *BaseResponse
    Data []* `xml:"data,omitempty"` //missing object type
}

This may be a limitation of the project that I'm just not aware of, but I figured I would raise an issue just in case.

@c4milo
Copy link
Member

c4milo commented Nov 5, 2014

hm, looks like an issue indeed. I'm looking into it.

@c4milo
Copy link
Member

c4milo commented Nov 6, 2014

@beckler I'm still working on this, that WSDL uncovered a couple of issues with attributes. Also, the schema doesn't reuse complex types but instead it embeds them inside elements which is kind of wacky but still valid XSD.

@c4milo
Copy link
Member

c4milo commented Nov 6, 2014

@beckler what I'm planing to do is to unwrap the embedded complex types since they are not being re-used anywhere else, leaving their fields become part of the parent type. This causes some clashes with existing attributes in the parent type so I'll see what I can do to fix that too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants