Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node update to 2.1.2 and minimum version set to 2.1.0 #546

Merged
merged 5 commits into from
Jul 10, 2024

Conversation

jeandemeusy
Copy link
Collaborator

@jeandemeusy jeandemeusy commented Jul 10, 2024

  • Update CT nodes to 2.1.2
  • Update Python SDK used version
  • Set min version required by CT to 2.1.0

Before merging, the tag v3.0.4 should be attached (in the GCP Artifact Registry) to the last commit of this PR.

Summary by CodeRabbit

  • New Features

    • Updated ctdapp core tag to v3.0.4 for improved performance and stability.
    • Switched blue-nodes from enabled to disabled in the production configuration.
    • Updated minVersion for peer configurations to 2.1.0.
  • Chores

    • Updated various configurations to use hoprd-sdk-python version 2.1.2.
    • Updated network configuration versions from 2.1.0 to 2.1.2 for consistency.

Copy link
Contributor

coderabbitai bot commented Jul 10, 2024

Walkthrough

Walkthrough

This update primarily encompasses version upgrades and configuration changes across multiple files to ensure consistency and compatibility within the system. Modifications include updating dependencies, peer versions, and Helm configuration values. These changes aim to improve the application's stability and performance, reflecting a step towards maintaining up-to-date software components.

Changes

Files Change Summary
ct-app/requirements.txt Updated hoprd-sdk-python from 2.1.0 to 2.1.2.
ct-app/scripts/core_prod_config.yaml Updated peer minVersion from '2.0.7' to '2.1.0'.
ct-app/scripts/core_staging_config.yaml Updated peer minVersion from '2.0.7' to '2.1.0'.
helm/values-prod-blue.yaml Updated version from 2.1.0 to 2.1.2.
helm/values-prod-green.yaml Updated version from 2.1.0 to 2.1.2 under the network configuration.
helm/values-prod.yaml Changed blue-nodes to enabled: false, updated ctdapp core tag from v3.0.3 to v3.0.4.
helm/values-staging.yaml Changed green-nodes enabled property from true to false.
helm/values-prod.yaml Updated ctdapp core tag from v3.0.3 to v3.0.4.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 00229f8 and 7477f2c.

Files selected for processing (5)
  • ct-app/requirements.txt (1 hunks)
  • ct-app/scripts/core_prod_config.yaml (1 hunks)
  • ct-app/scripts/core_staging_config.yaml (1 hunks)
  • helm/values-prod-blue.yaml (1 hunks)
  • helm/values-prod-green.yaml (1 hunks)
Files skipped from review due to trivial changes (5)
  • ct-app/requirements.txt
  • ct-app/scripts/core_prod_config.yaml
  • ct-app/scripts/core_staging_config.yaml
  • helm/values-prod-blue.yaml
  • helm/values-prod-green.yaml

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7477f2c and 92c60c9.

Files selected for processing (2)
  • helm/values-prod.yaml (2 hunks)
  • helm/values-staging.yaml (1 hunks)
Additional comments not posted (3)
helm/values-prod.yaml (2)

2-2: LGTM! Blue nodes disabled.

The change aligns with the PR objectives.


13-13: LGTM! ctdapp core tag updated.

The change aligns with the PR objectives.

helm/values-staging.yaml (1)

4-4: LGTM! Green nodes disabled.

The change aligns with the PR objectives.

@jeandemeusy jeandemeusy changed the title Update nodes to 2.1.2 Node update to 2.1.2 and minimum version set to 2.1.0 Jul 10, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 92c60c9 and accac6a.

Files selected for processing (1)
  • helm/values-prod.yaml (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • helm/values-prod.yaml

@jeandemeusy jeandemeusy merged commit 0e8b5c2 into main Jul 10, 2024
2 checks passed
@jeandemeusy jeandemeusy deleted the update-to-2.1.2 branch July 10, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants