Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add from-adress to logs #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

cheese1
Copy link
Contributor

@cheese1 cheese1 commented Feb 9, 2021

it makes life for admins easier, if we see on screenshots under which identity/from-adress a user is having troubles to send messages. and have that info in horde.log without a user complaining, too.

@yunosh
Copy link
Member

yunosh commented Feb 17, 2021

Since this is a per-user setting, it doesn't make sense to report the identity that has been used.

@cheese1
Copy link
Contributor Author

cheese1 commented Feb 23, 2021

you mean, because the user could change (if permitted) its own identity?
maybe one could log the "username" which was used at login.

@cheese1
Copy link
Contributor Author

cheese1 commented Feb 23, 2021

you mean, because the user could change (if permitted) its own identity?
maybe one could log the username which was used at login.

maybe better to use getAuth() than the from-header, as the enduser cannot modify/fake that (i assume)
ralflang added a commit that referenced this pull request Dec 22, 2023
Adds an option to toggle the `Received` headers for HTTP connections in Compose.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants