Changes to support phpunit 9.x from Debian for FRAMEWORK_6 branch #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralflang
approved these changes
Dec 4, 2023
| @@ -28,9 +28,9 @@ | |||
| * @link http://www.horde.org/apps/mnemo | |||
| */ | |||
| class Mnemo_TestCase | |||
| extends PHPUnit_Framework_TestCase | |||
| extends Horde_Test_Case | |||
There was a problem hiding this comment.
I am not sure I agree with that move.
- We should use the namespaced tree Horde\Test\Case
- If it works with a bare Phpunit\Framrwork\Testcase, we should probably use that.
There was a problem hiding this comment.
OTOH I can follow up on this separately. I don't want to delay / burden your otherwise uncontroversial fix to the unit tests
There was a problem hiding this comment.
Hi Ralf, the following is working for me:
use PHPUnit\Framework\TestCase;
class Mnemo_TestCase
extends TestCase
That would be solution 2. you prefer, or?
| { | ||
| public function setUp() | ||
| public function setUp(): void | ||
| { |
There was a problem hiding this comment.
Yes, the return type must be added either way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ralflang here the phpunit9.x changes for the FRAMEWORK6.0 branch.