feature(+script #100): k3s can be installed locally #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilosonc
reviewed
Mar 29, 2023
scripts/install.sh
Outdated
| installingress | ||
| fi | ||
|
|
||
| install |
kilosonc
reviewed
Mar 29, 2023
scripts/install.sh
Outdated
| @@ -454,6 +438,25 @@ EOF | |||
| kubectl wait --for=condition=complete --timeout=60s -nhorizoncd job/horizon-init | |||
| } | |||
|
|
|||
| function checkk3s(){ | |||
There was a problem hiding this comment.
move this into checkprerequesites
scripts/install.sh
Outdated
| k3s server & | ||
| } | ||
|
|
||
| function checkandinstallk3s(){ |
scripts/install.sh
Outdated
| install | ||
|
|
||
| if ! $CLOUD | ||
| if ! $CLOUD && ! $K3S |
feature(scripts): Add k3s to the production script feature(makefile): Supports local deployment of k3s Optimize the install script to add k3s Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
2 tasks
|
@kilosonc Help me test this PR |
|
This issue is stale because it has been open 30 days with no activity. |
|
This PR was closed because it has been stalled for 5 days with no activity. You can reopen it if you want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved: #100
Design and discussion: #81
Please give suggestions ~