Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better support for different BMC hardware #16

Closed
wants to merge 1 commit into from
Closed

Better support for different BMC hardware #16

wants to merge 1 commit into from

Conversation

myMarck
Copy link
Contributor

@myMarck myMarck commented May 30, 2018

Changed the parameter type to a array to its not needed to add new parameters when/if more BMC is supported.
Improved documentation.
Changed from wget to curl because wget is not default installed on Rhel/Centos 7.5

@myMarck myMarck requested a review from enemarke May 30, 2018 12:50
@myMarck
Copy link
Contributor Author

myMarck commented May 30, 2018 •
edited
Loading

This request breaks API so version should be bumped to 0.1.0
And CHANGELOG.md should contain something like

## Supported Release 0.1.0
### Summary
* bmc
    - change parameter name to manage_oem_repo because it more informativ.
    - change parameter name and type to oem_software of type Array to better support remote setup.

@myMarck myMarck closed this May 30, 2018
@myMarck myMarck deleted the config_remote branch June 4, 2018 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enemarke enemarke Awaiting requested review from enemarke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@myMarck