Fix ZugferdPdfWriter not outputting metadata if there are no files #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background information
A customer requires to receive only a single XML with a PDF embedded as base64.
This task was easy to manage using addDocumentAdditionalReferencedDocument().
I wanted to avoid having a XML containing a PDF which itself contains an XML (Matrjoschka), so I just did a XML containing a PDF.
Although not required, I thought that it would be a nice touch if the embedded PDF was PDF/A-3B instead of a plain PDF. So, I wrote a method based on ZugferdPdfWriter, which converts a plain PDF to PDF/A-3B (without attachments).
The bug
ZugferdPdfWriter has the problem that it does not write any metadata information if no files are included.
This PR fixes the issue.
While it does not affect the "normal usage" of this library, it fixes a problem where other people developing/extending the library might stumble upon.