Skip to content
This repository has been archived by the owner on Nov 14, 2023. It is now read-only.

Document class design #13

Closed
robsavoye opened this issue Oct 6, 2021 · 3 comments · Fixed by #55
Closed

Document class design #13

robsavoye opened this issue Oct 6, 2021 · 3 comments · Fixed by #55
Assignees
Labels

Comments

@robsavoye
Copy link
Collaborator

There are many endpoints in the User stories, but they do break down into related groups of data queries., To avoid code duplication, a design document should identify base classes that can be shared by higher level classes. For example related queries about user statistics might have similar functionality, and should share code that uses arguments to the methods to change behavior. This will help determine the implementation of the data flow of the API, which is better to do now while the project is small and fluid. While currently the endpoints are relatively simple, there will be growing complexity as more endpoints get implemented.

@kshitijrajsharma
Copy link
Member

Related to #7

@robsavoye
Copy link
Collaborator Author

Looking at the current code under the osmstats directory, I notice a lot of filters. Something to consider, is this generic functionality that should be in a base class ? This could force some refactoring of how the filters work.

@kshitijrajsharma
Copy link
Member

Looking at the current code under the osmstats directory, I notice a lot of filters. Something to consider, is this generic functionality that should be in a base class ? This could force some refactoring of how the filters work.

@JorgeMartinezG

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants