Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented: aligned picklist date and arrow. #152

Merged
merged 4 commits into from
Aug 17, 2023

Conversation

sanskar345
Copy link
Contributor

@sanskar345 sanskar345 commented Aug 3, 2023

Related Issues

Closes #138

Short Description and Why It's Useful

Overriden these two properties of ion-note as inherited when used with ion-item --

Previously:
align-self: flex-start;
padding: 18px 0px 10px;

Changed:
align-self: center;
padding: 0;

Screenshots of Visual Changes before/after (If There Are Any)

Before -
before
After -
44444

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and Currently Important Rules Acceptance

@sanskar345 sanskar345 marked this pull request as ready for review August 3, 2023 12:30
@dt2patel
Copy link
Contributor

dt2patel commented Aug 4, 2023

we will not use this solution because it breaks the native styling of ionic note component that it inherits by being inside an ion-item

@sanskar345 sanskar345 marked this pull request as draft August 4, 2023 09:28
@sanskar345
Copy link
Contributor Author

Will try to find another solution.

@sanskar345
Copy link
Contributor Author

@dt2patel Sir if we override these two properties of ion-note as inherited when used with ion-item things work --

Previously:
align-self: flex-start;
padding: 18px 0px 10px;

Changed:
align-self: center;
padding: 0;

We do not require any padding and want to align it in the center of the flexbox. We can create a class for overriding these properties.

@dt2patel
Copy link
Contributor

@sanskar345 that is a good solution. for now lets only put it on this page's css. later we may consider making it part of our global css

@sanskar345 sanskar345 marked this pull request as ready for review August 17, 2023 05:13
src/components/Picklist-item.vue Outdated Show resolved Hide resolved
@dt2patel dt2patel merged commit 1da0188 into hotwax:main Aug 17, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The picklist date and arrow are not aligned.
2 participants