Turbo navigator feedback #161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivaresf
force-pushed
the
fernando/turbo-navigator-feedback
branch
from
00de565
to
ec73f89
Compare
Naming is quite general. I'd prefer if we could change it to something omre specific.
|
That last issue with the namespace is actually complicated to solve. I'll table that one for now, so please don't merge the branch as-is. I can open up a new one or you can cherry pick the other commits from here! |
|
Everything but the |
Of course! I'll do it today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three minor things and one major thing. Feel free to cherry-pick any commits to your branch or merge if all commits are good!
PathConfigurationIdentifiableNavigationtoTurboNavigationTurboenum as it's creating a collision with the frameworkThe last point requires a bit of explanation: if an app that imports Turbo (the framework) has a class/struct with the same name as a turbo class/struct the compiler is unable to disambiguate which class/struct should be used.
For example, let's say the Demo app has a class named
Session. Turbo has a class namedSessiontoo. In theory, there's no collision because they both exist in different namespaces. In order to use the app's Session, you'd explicitly declare it asDemoApp.Session. In order to use Turbo's, you'd sayTurbo.Session.However, since there exists an enum named
Turbo, the compiler cannot disambiguate between:Turbo.Session(trying to call class Session from framework Turbo)Turbo.Session(trying to access a case or property from enum Turbo).We should avoid naming classes/structs the same as the framework. If we're set on keeping the
enum(which I don't like), we should at least rename it to something else.I noticed Strada is doing this too. We need to fix it there too.
Let me know what you think!