Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require AttributeAccessorsPerThread #523

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Conversation

sevos
Copy link
Contributor

@sevos sevos commented Nov 24, 2023

This is the same patch as in #508
The PR got merged into the feature branch after the feature was merged to the main branch.

Fixes library loading error in edge Rails.

Repository reproducing the problem: https://github.com/sevos/example_rails_turbo_morph

I've tested the library with Rails 7.2 (main branch), and the library failed to load with the undefined method thread_mattr_accessor on Turbo:Module error. Locally, I fixed it by requiring the appropriate file from ActiveSupport before loading Gemfile in application.rb. This PR should fix this.

Fixes library loading error in edge Rails
Copy link
Member

@jorgemanrubia jorgemanrubia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sevos

@jorgemanrubia jorgemanrubia merged commit 8a3dae9 into hotwired:main Nov 24, 2023
0 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants