Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use safe operator when calling to request in turbo_frame_request_id #532

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Use safe operator when calling to request in turbo_frame_request_id #532

merged 1 commit into from
Feb 7, 2024

Conversation

brunoprietog
Copy link
Contributor

Fixes #529

@brunoprietog brunoprietog mentioned this pull request Nov 30, 2023
Closed
jorgemanrubia
jorgemanrubia approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@jorgemanrubia jorgemanrubia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brunoprietog!

@jorgemanrubia jorgemanrubia merged commit 468a0a4 into hotwired:main Feb 7, 2024
@brunoprietog brunoprietog deleted the safe-operator-turbo_frame_request_id branch February 7, 2024 10:02
@eugeneius eugeneius mentioned this pull request Apr 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgemanrubia jorgemanrubia jorgemanrubia approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with render_to_string method of ActionController. "Could not render layout: undefined method headers"
2 participants
@brunoprietog @jorgemanrubia