-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for globally opting-out of behaviors? #77
Comments
I think we should wait for some real world cases that demand this before preemptively adding such configurations. I mean, I can imagine this maybe useful to some, but I'd like to see a real case before we add the additional weight. |
Yeah, my only real world case is that I have a large app with lots of forms -- some are |
Yeah, that sounds fair. I'd be fine seeing a toggle for each element. |
I was thinking exactly the same. In my case I'd like to be able to:
I don't know if this would be feasible with the current implementation (didn't check yet). But at least from a developer's point of view would be clear IMO. |
This has been resolved in https://github.com/hotwired/turbo/releases/tag/v7.0.0-beta.2 -- opt-out of the form behavior with If you want to only opt-out of forms, you can put |
👋
Wondering if there would be an appetite for adding a configuration/setting to opt-out of some of the Turbo modules.
If you only wanted the TurboDrive for links, it might be nice to support a global opt-out of the
formSubmitObserver
. If you aren't using Frames or Streams, you could opt-out of thestreamObserver
,frameRedirector
, etc.There are sometimes ways to opt-out of these behaviors on a per-page, per-form, or per-link basis, but I think it would smooth adoption / upgrading from Turbolinks if you could opt-in piecemeal.
I don't think it's a slam dunk, especially since the installation path is really nice and there is no config/settings (outside of the progress timeout). Happy to help implement if there is interest, but wanted to gauge support.
The text was updated successfully, but these errors were encountered: