[Jormun] optim geovelo #2711
[Jormun] optim geovelo #2711
Conversation
| routing.routing_status = response_pb2.unknown | ||
|
|
||
| add_ = row.routing_response.add | ||
| for e in itertools.islice(json_response, 1, sys.maxint): |
There was a problem hiding this comment.
Why not use None for stop?
And are we sure that geovelo keep the request order? And by sure I mean does is it documented?
There was a problem hiding this comment.
since in the old code, we didn't check the order... I assumed that the order was kept
| ) | ||
| self._check_response(r) | ||
| resp_json = r.json() | ||
| resp_json = ujson.loads(r.text) |
There was a problem hiding this comment.
https://github.com/kennethreitz/requests/issues/1595
It will be nice to have it for everyone :)
There was a problem hiding this comment.
actually, i was looking forward to being able to specify the json module in .json(), like r.json(json_module=ujson)...
There was a problem hiding this comment.
mypy doesn't like requests.models.json = ujson
| @@ -104,8 +108,8 @@ def _make_request_arguments_bike_details(cls, bike_speed_mps): | |||
| @classmethod | |||
| def _make_request_arguments_isochrone(cls, origins, destinations, bike_speed_mps=3.33): | |||
| return { | |||
| 'starts': [cls._pt_object_summary_isochrone(o) for o in origins], | |||
| 'ends': [cls._pt_object_summary_isochrone(o) for o in destinations], | |||
| 'starts': (cls._pt_object_summary_isochrone(o) for o in origins), | |||
There was a problem hiding this comment.
usjon has difficulties with generators as reported in several issues... what a pity...
Codecov Report
@@ Coverage Diff @@
## dev #2711 +/- ##
=======================================
- Coverage 86.9% 86.8% -0.1%
=======================================
Files 392 392
Lines 58877 58842 -35
=======================================
- Hits 51174 51122 -52
- Misses 7703 7720 +17 |
https://jira.kisio.org/browse/NAVITIAII-2675
-> use compress protocol
-> simplify useless fields
-> use ujson
-> pythonic optim