Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add administrative regions #45

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Add administrative regions #45

merged 2 commits into from
Oct 9, 2023

Conversation

datanel
Copy link
Member

@datanel datanel commented Sep 29, 2023 •
edited
Loading

datanel
datanel commented Sep 29, 2023
View reviewed changes
ntfs_fr.md Outdated Show resolved Hide resolved
ntfs_fr.md Outdated Show resolved Hide resolved
@datanel datanel requested a review from pbench September 29, 2023 13:44
ArnaudOggy
ArnaudOggy reviewed Sep 29, 2023
View reviewed changes
ntfs_fr.md Outdated Show resolved Hide resolved
@datanel datanel force-pushed the admin_regions branch 4 times, most recently from fdabf2e to 011c3e5 Compare September 29, 2023 14:20
ArnaudOggy
ArnaudOggy reviewed Sep 29, 2023
View reviewed changes
ntfs_fr.md Outdated Show resolved Hide resolved
@ArnaudOggy ArnaudOggy self-requested a review September 29, 2023 16:01
woshilapin
woshilapin reviewed Oct 2, 2023
View reviewed changes
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is an alternative proposition to get a hierarchical organization of the same information. How about addresses.txt only getting one new field admin_level_id referring to the lowest administrative region. And then, in administration_regions.txt, adding a new field name admin_parent_id that links all of them as a tree?

ntfs_fr.md Outdated Show resolved Hide resolved
@datanel datanel force-pushed the admin_regions branch 2 times, most recently from d3f67f5 to 7e51277 Compare October 3, 2023 08:14
@datanel datanel mentioned this pull request Oct 5, 2023
Merged
ArnaudOggy
ArnaudOggy reviewed Oct 5, 2023
View reviewed changes
ntfs_fr.md Outdated Show resolved Hide resolved
@datanel @ArnaudOggy
fix grammar
529336e 
Co-authored-by: Arnaud Oggy <arnaud.ogiela@canaltp.fr>
@datanel datanel merged commit f6f96dd into master Oct 9, 2023
@datanel datanel deleted the admin_regions branch October 9, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woshilapin woshilapin woshilapin left review comments

@pbench pbench pbench approved these changes

@ArnaudOggy ArnaudOggy ArnaudOggy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@datanel @woshilapin @ArnaudOggy @pbench