Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Full comment deduplication for referential objects, based on name only for similarity #685

Merged
merged 5 commits into from
Aug 6, 2020

Conversation

pbougue
Copy link
Contributor

@pbougue pbougue commented Aug 5, 2020

Schedule objects are not handled, as no merge is done for them (duplicates would only be the result of initial data).

Ref. ND-979

TODO:

  • Check tests are OK for libs depending on this

@pbougue pbougue requested a review from ArnaudOggy August 5, 2020 10:38
src/model.rs Outdated Show resolved Hide resolved
Pierre-Etienne Bougue added 2 commits August 5, 2020 17:31
And use &str intead of String for 'intersection' Vec.
src/model.rs Outdated Show resolved Hide resolved
src/model.rs Outdated Show resolved Hide resolved
@datanel datanel merged commit f5eea7c into hove-io:master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants