[feature] Gtfs2Ntfs: added parameter --schedule-prefix #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datanel
force-pushed
the
schedule_subprefix
branch
2 times, most recently
from
3a45f02
to
ba39dfd
Compare
pbougue
reviewed
Aug 7, 2020
There was a problem hiding this comment.
👍 It looks fine.
Is it possible to add a test without subprefix set and check that we only have prefix (as allowing it is the main goal of that change)?
Maybe also test with subprefix but no prefix, and none of the two would be nice.
(don't know if some are already tested appart of this PR, though).
datanel
force-pushed
the
schedule_subprefix
branch
from
6e279b8
to
6c7bf20
Compare
datanel
force-pushed
the
schedule_subprefix
branch
from
6c7bf20
to
1ca8b85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: ND-993
This is a breaking change. schedule prefix is no longer automatically created by the 6 characters of the dataset id.
a new parameter
--schedule-prefixhas been added and may be provided ingtfs2ntfs+ some markdown linting