-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Default forbid pickup/dropoff on last/first stop times of vehicle journeys #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patochectp
reviewed
Sep 11, 2020
Some updates about this PR (removing the
|
A small improvement, I moved the |
pbougue
reviewed
Sep 15, 2020
woshilapin
force-pushed
the
smart-pickup-dropoff
branch
from
September 16, 2020 08:38
9d01051
to
07d49e5
Compare
pbougue
approved these changes
Sep 16, 2020
pbougue
approved these changes
Sep 16, 2020
patochectp
approved these changes
Sep 16, 2020
woshilapin
force-pushed
the
smart-pickup-dropoff
branch
from
September 16, 2020 15:47
0e5e404
to
9f498a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For trip planning to be handled correctly by Navitia, we need to forbid pick-up on the last stop time of each vehicle journey and drop-off on the first stop time of each vehicle journey. However, there is one specific case when we still want to leave the possibility of pick-up on the last and drop-off on the first: prolongation trips when the last stop of the first trip and the first stop of second trip are different.
ref: ND-991.