Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Add model builder into transit_model #936

Merged
merged 5 commits into from
Jan 17, 2024
Merged

[feature] Add model builder into transit_model #936

merged 5 commits into from
Jan 17, 2024

Conversation

datanel
Copy link
Member

@datanel datanel commented Jan 15, 2024

  1. Commit 1/2: move ModelBuilder from model-builder crate to transit_model. It will easier to maintain and to use from another crate
  2. Commit 3: add more functions

woshilapin
woshilapin approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice rework, and it's going to be much easier to maintain it I believe... and maybe use it somewhere else 🤷 😄 Thanks for the nice commit splitting, really helped to review the PR.

@datanel datanel marked this pull request as draft January 17, 2024 09:17
@datanel datanel marked this pull request as ready for review January 17, 2024 11:21
@datanel datanel merged commit a4f1a6a into master Jan 17, 2024
13 checks passed
@datanel datanel deleted the model-builder branch January 17, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woshilapin woshilapin woshilapin approved these changes

@ArnaudOggy ArnaudOggy ArnaudOggy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@datanel @woshilapin @ArnaudOggy