Storage | Added Redis storage #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@guillaumepotier This new PR looks really good! I'm trying to test it right now. Any recommendations on where I get some free Redis hosting? |
|
Just used redistogo.com. Your PR passes |
|
Great! Best |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #38, dunno why, had problems during rebase and ended up by forking again the project to make it possible in a simple clear commit.
Some thoughts:
allById()methods which I find handy. I can totally remove it and implement it back in my project if you find it not suitable for hereunit.js, and maybemonkandredisto make all the tests passBest