Streamline synchronous processing #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…del similar to filepath.Walk so that ledger.ParseLedger doesn't have to incur memory and context switching overhead of channels and goroutines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved ledger parsing logic into a helper function using a callback model similar to filepath.Walk so that ledger.ParseLedger doesn't have to incur memory and context switching overhead of channels and goroutines.
This change results in a 10x performance improvement and a significant reduction in allocations for the existing benchmark.
Before:
BenchmarkParseLedger-8 300000 3380 ns/op 4336 B/op 6 allocs/op
After:
BenchmarkParseLedger-8 3000000 528 ns/op 4096 B/op 1 allocs/op
Resolves issue #18