Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake find Mercury and MPI #149

Closed
jeanbez opened this issue Oct 11, 2023 · 1 comment
Closed

cmake find Mercury and MPI #149

jeanbez opened this issue Oct 11, 2023 · 1 comment
Labels
priority: low Low priority type: bug Something isn't working
Milestone
v.0.4

Comments

@jeanbez
Copy link
Member

jeanbez commented Oct 11, 2023

We have two FindMercury files in cmake. However, in a fresh Ubuntu install, neither seem to be working as they should. I got no configuration errors but during build time it does not find the mercury.h and mpi.h headers. We should fix this so that the headers are checked during configure time and handle that appropriately.

@zhangwei217245 I saw you created this second find Mercury file. Could you please confirm why we have two there?
@jeanbez jeanbez added type: bug Something isn't working priority: medium Medium priority labels Oct 11, 2023
@jeanbez jeanbez added this to the v.0.4 milestone Oct 11, 2023
@zhangwei217245 zhangwei217245 added priority: low Low priority and removed priority: medium Medium priority labels Oct 11, 2023
@zhangwei217245
Copy link
Collaborator

zhangwei217245 commented Oct 11, 2023 •
edited
Loading

Interestingly, on my local workspace, there is only one FindMercury.cmake file and not sure why there are two in the repo.

I roughly remembered that I changed the file name either from FindMERCURY.cmake to FindMercury.cmake or from FindMercury.cmake to FindMERCURY.cmake.

talked to @jeanbez and based on the fact that both githubCI and NERSC-CI can still work, we agree to lower the priority of this issue for now.

@zhangwei217245 zhangwei217245 mentioned this issue Oct 12, 2023
Merged
zhangwei217245 added a commit that referenced this issue Oct 13, 2023
@zhangwei217245
IDIOMS v0.9 (#151)
6588b7d 
Major changes:

DART integration - single-client v.s. multi-client queries, suffix-tree mode
Benchmark -> mpi_query_scale_col
docker support for local development (very useful if you don't have a proper linux environment) Develop a docker image for developing/testing/debugging PDC. #150
Other changes:

unifying all work_todo_g and bulk_todo_g to use atomic operations
Github codespace support -> initiative
fixing duplicated FindMercury.cmake cmake find Mercury and MPI #149
jeanbez pushed a commit that referenced this issue Jan 9, 2024
@zhangwei217245 @jeanbez
IDIOMS v0.9 (#151)
054f2c3 
Major changes:

DART integration - single-client v.s. multi-client queries, suffix-tree mode
Benchmark -> mpi_query_scale_col
docker support for local development (very useful if you don't have a proper linux environment) Develop a docker image for developing/testing/debugging PDC. #150
Other changes:

unifying all work_todo_g and bulk_todo_g to use atomic operations
Github codespace support -> initiative
fixing duplicated FindMercury.cmake cmake find Mercury and MPI #149
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: low Low priority type: bug Something isn't working
Projects
None yet
Milestone
v.0.4
Development

No branches or pull requests
2 participants
@zhangwei217245 @jeanbez