You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Need to address python3. Either explicitly require python2, print a friendly message, and exit or make give.py python3 compatible.
Currently, for a user with python3 in their env, give crashes at the print and produces a syntax error.
@dayr has this come up as an issue at LLNL? @jennfshr@dayr any preference on implementation?
I will merge Ryan's previous changes into master. If we switch to python3 compatibility, we should branch and version up. If we explicitly require python 2, we should minor version up.
The text was updated successfully, but these errors were encountered:
I don't think we've run into that problem much here, but problems with
people using their own python builds have surfaced from time to time. I
also don't think we have any plans to switch to python 3 as our default any
time soon, but I'll double check on that. If it's possible to write give to
be compatible with 2 and 3, that seems like the best course. I don't have
any feel for how much effort that would require though.
I will merge Ryan's previous changes into master. If we switch to python3
compatibility, we should branch and version up. If we explicitly require
python 2, we should minor version up.
—
Reply to this email directly or view it on GitHub #1.
I've converted the give.py.in code to python3. It was mostly making print calls to be a function call. There was one minor change that I'm still investing. I will test thoroughly using python2 and 3 on a TOSS cluster here at lanl. If it builds and runs fine, I will roll a new rpm for toss and submit a pull request.
Need to address python3. Either explicitly require python2, print a friendly message, and exit or make give.py python3 compatible.
Currently, for a user with python3 in their env, give crashes at the print and produces a syntax error.
@dayr has this come up as an issue at LLNL?
@jennfshr @dayr any preference on implementation?
I will merge Ryan's previous changes into master. If we switch to python3 compatibility, we should branch and version up. If we explicitly require python 2, we should minor version up.
The text was updated successfully, but these errors were encountered: