Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3 compatability #1

Closed
dmanno opened this issue Mar 9, 2016 · 2 comments
Closed

Python3 compatability #1

dmanno opened this issue Mar 9, 2016 · 2 comments
Assignees

Comments

@dmanno
Copy link
Contributor

dmanno commented Mar 9, 2016

Need to address python3. Either explicitly require python2, print a friendly message, and exit or make give.py python3 compatible.

Currently, for a user with python3 in their env, give crashes at the print and produces a syntax error.

@dayr has this come up as an issue at LLNL?
@jennfshr @dayr any preference on implementation?

I will merge Ryan's previous changes into master. If we switch to python3 compatibility, we should branch and version up. If we explicitly require python 2, we should minor version up.

@dayr
Copy link

dayr commented Mar 18, 2016

I don't think we've run into that problem much here, but problems with
people using their own python builds have surfaced from time to time. I
also don't think we have any plans to switch to python 3 as our default any
time soon, but I'll double check on that. If it's possible to write give to
be compatible with 2 and 3, that seems like the best course. I don't have
any feel for how much effort that would require though.

Ryan

On Wed, Mar 9, 2016 at 10:29 AM, Dominic Manno notifications@github.com
wrote:

Need to address python3. Either explicitly require python2, print a
friendly message, and exit or make give.py python3 compatible.

Currently, for a user with python3 in their env, give crashes at the print
and produces a syntax error.

@dayr https://github.com/dayr has this come up as an issue at LLNL?
@jgreen https://github.com/jgreen @dayr https://github.com/dayr any
preference on implementation?

I will merge Ryan's previous changes into master. If we switch to python3
compatibility, we should branch and version up. If we explicitly require
python 2, we should minor version up.


Reply to this email directly or view it on GitHub
#1.

@dmanno
Copy link
Contributor Author

dmanno commented May 25, 2016

I've converted the give.py.in code to python3. It was mostly making print calls to be a function call. There was one minor change that I'm still investing. I will test thoroughly using python2 and 3 on a TOSS cluster here at lanl. If it builds and runs fine, I will roll a new rpm for toss and submit a pull request.

@dmanno dmanno self-assigned this Sep 28, 2017
@dmanno dmanno closed this as completed in 462387f Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants