-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cmake check for libattr #511
Conversation
@ofaaland , would you please review this when you get a chance? If you have suggestions, please let me know. In case someone doesn't have libattr installed, I protected the libattr-related lines with a I also dropped the input |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think we should leave LibAttr as "REQUIRED" for the moment since there is no easy way for the user to tell whether libattr support was built (if they don't know about tools like ldd)
Signed-off-by: Adam Moody <moody20@llnl.gov>
Signed-off-by: Adam Moody <moody20@llnl.gov>
@adammoody To be clear, the current (and intended) behavior is that |
@daltonbohning , yes, that's the goal, but we're assuming that one has libattr available. If we find common setups that use xattrs but do not have libattr installed, I think we could do more work to make libattr optional. |
@adammoody Thanks. Luckily, so far it seems our (DAOS) setups do have libattr installed/available. |
This adds a cmake find_package check for libattr, which is used for
attr_copy_action
when copying extended attributes. When xattr support is enabled, libattr is marked as required. However, this also adds compile-time checks in the code to disable libattr code if is was not found so that it could be optional rather than required.